While different theoretical frameworks have been proposed to characterise the nature of feedback and the conditions under which feedback contributes to student learning, few empirical studies have examined the usefulness of these theoretical frameworks to understand student feedback experiences in classrooms particularly in a pre-service context. This article explores what classroom feedback practices trainee teachers experience, and how their feedback experiences relate to their learning motivation. The paper presents the results of questionnaire surveys conducted with 276 pre-service ESL trainee teachers in a BEd English education programme. The study found that trainee teachers in this study experienced predominantly activity-based feedback and teacher evaluation feedback, while peer/self feedback and longitudinal-development feedback were relatively infrequently used in the classroom. However, peer/self feedback and longitudinal-development feedback appeared to be most powerful in predicting positive motivational processes, followed by activity-based feedback and teacher evaluation feedback.